Skip to content

Conversation

poppinlp
Copy link

As we mentioned here. And some handy things.

  • Use files field to specify included files.
  • Remove preferGlobal since it's deprecated.
  • Add more node version in .travis.yml.
  • Fix some lint errors in lib/plugins/cache.js.
  • Update .gitignore from gitignore repo.

@poppinlp
Copy link
Author

BTW. Looks like some test cases for plugins are broken in master branch. But I haven't look into it yet.
image

@jdneo
Copy link

jdneo commented Apr 21, 2019

Thank you @poppinlp

One nit is that there is no need to test Node.js on 4, 6 (the extension requires 8 at least)

@poppinlp
Copy link
Author

@jdneo OK. I'll fix it tonight. Sorry for my late reply. I'm in Vietnam recently.

@jdneo jdneo requested a review from Vigilans April 24, 2019 11:23
Copy link

@jasonchaw jasonchaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants